fix(desktop): make triple-click select only the clicked composer line - #6450
Open
kltdwrds wants to merge 1 commit into
Open
fix(desktop): make triple-click select only the clicked composer line#6450kltdwrds wants to merge 1 commit into
kltdwrds wants to merge 1 commit into
Conversation
Shift+Enter never starts a new paragraph in the Tiptap composer -- a multi-line typed message is one <p> with inline hardBreak (<br>) nodes. Browsers resolve triple-click by expanding to the nearest block container, so triple-clicking any line selected the entire composer content instead of just that line. Pasted multi-line text is unaffected since it parses into separate <p> nodes. Adds a tripleClickSelectsLine ProseMirror plugin that intercepts handleTripleClick and reuses the existing hardBreakLineBounds() helper (already used for Ctrl-A/Ctrl-E/Ctrl-K Emacs-style shortcuts) to select just the text between the surrounding hard breaks. Adds an E2E regression spec verifying triple-click on a middle line of a three-line hard-break message selects only that line. Signed-off-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shift+Enter never starts a new paragraph in the Tiptap composer -- a multi-line typed message is one
with inline hardBreak (
) nodes. Browsers resolve triple-click by expanding to the nearest block container, so triple-clicking any line selected the entire composer content instead of just that line. Pasted multi-line text is unaffected since it parses into separate
nodes.
Adds a tripleClickSelectsLine ProseMirror plugin that intercepts handleTripleClick and reuses the existing hardBreakLineBounds() helper (already used for Ctrl-A/Ctrl-E/Ctrl-K Emacs-style shortcuts) to select just the text between the surrounding hard breaks.
Adds an E2E regression spec verifying triple-click on a middle line of a three-line hard-break message selects only that line.
Summary
Related issue
Testing